spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhichao-li <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12789]Support order by index
Date Fri, 05 Feb 2016 07:41:51 GMT
Github user zhichao-li commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10731#discussion_r51985561
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -322,6 +323,62 @@ class Analyzer(
       }
     
       /**
    +    * Replace the index with the related attribute for order by and group by.
    +    */
    +  object ResolveIndexReferences extends Rule[LogicalPlan] {
    +
    +    def indexToColumn(
    +        sortOrder: SortOrder,
    +        child: LogicalPlan,
    +        index: Int,
    +        direction: SortDirection): SortOrder = {
    +      val orderNodes = child.output
    +      if (index > 0 && index <= orderNodes.size) {
    +        SortOrder(orderNodes(index - 1), direction)
    +      } else {
    +        throw new UnresolvedException(sortOrder,
    +          s"""Order by position: $index does not exist \n
    +              |The Select List is indexed from 1 to ${orderNodes.size}""".stripMargin)
    +      }
    +    }
    +
    +    def indexToColumn(
    +        agg: Aggregate,
    +        child: LogicalPlan,
    +        index: Int): Expression = {
    +      val attributes = child.output
    +      if (index > 0 && index <= attributes.size) {
    +        attributes(index - 1)
    +      } else {
    +        throw new UnresolvedException(agg,
    +          s"""Aggregate by position: $index does not exist \n
    +              |The Select List is indexed from 1 to ${attributes.size}""".stripMargin)
    +      }
    +    }
    +
    +    def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
    +      case s @ Sort(orders, global, child) if child.resolved =>
    --- End diff --
    
    Have thought of this for a while, but still cannot come up with a concrete solution for
such nested type. Not sure if you can provide any snippet as a suggestion? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message