spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhemanth <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10155][SQL]Change SqlParser to object t...
Date Fri, 05 Feb 2016 00:58:26 GMT
Github user yhemanth commented on the pull request:

    https://github.com/apache/spark/pull/8357#issuecomment-180131377
  
    @zsxwing - we ran into the same issue on our project, Apache Atlas [here](https://issues.apache.org/jira/browse/ATLAS-471).
I have looked up a few other references to this bug and this fix seemed clearer to me than
others. I was planning to model the fix in this same manner. Just one question - why did you
need to add a synchronized? Is it because it wasn't very clear whether the threading issue
was fixed or not in SI-4929, or because you are clear that the threading issue still exists
with the memory leak? In our case, we are a server side app, hence adding a synchronized could
impact performance non-trivially. Any information you can provide would be of great help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message