spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12992][SQL] Support vectorized decoding...
Date Thu, 04 Feb 2016 17:53:10 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11055#discussion_r51909811
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
    @@ -716,6 +788,28 @@ private void readLongBatch(int rowId, int num, ColumnVector column)
throws IOExc
           }
         }
     
    +    private void readFloatBatch(int rowId, int num, ColumnVector column) throws IOException
{
    +      // This is where we implement support for the valid type conversions.
    +      // TODO: implement remaining type conversions
    --- End diff --
    
    I think the dataType could only be FloatType


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message