spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nongli <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...
Date Tue, 02 Feb 2016 20:39:53 GMT
Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10989#discussion_r51631359
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
    @@ -389,14 +379,16 @@ case class TungstenAggregate(
            UnsafeRow $keyTerm = (UnsafeRow) $iterTerm.getKey();
            UnsafeRow $bufferTerm = (UnsafeRow) $iterTerm.getValue();
            $outputCode
    +
    +       if (shouldStop()) return;
    --- End diff --
    
    Can you document the required behavior of shouldStop(). How does it need to behave so
that the clean up below (hashMapTerm.free()) is called? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message