spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...
Date Tue, 02 Feb 2016 07:34:11 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10960#discussion_r51533793
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
    @@ -198,7 +198,8 @@ case class Window(
               functions,
               ordinal,
               child.output,
    -          (expressions, schema) => newMutableProjection(expressions, schema))
    +          (expressions, schema) =>
    +            newMutableProjection(expressions, schema, subexpressionEliminationEnabled))
    --- End diff --
    
    This would definitely help the computation of summary statistics. But would `subexpressionEliminationEnabled`
have other side effects? cc @nongli 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message