spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....
Date Tue, 02 Feb 2016 00:01:12 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8610#discussion_r51502059
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ---
    @@ -571,7 +571,8 @@ private[deploy] class Master(
           usableWorkers: Array[WorkerInfo],
           spreadOutApps: Boolean): Array[Int] = {
         val coresPerExecutor = app.desc.coresPerExecutor
    -    val minCoresPerExecutor = coresPerExecutor.getOrElse(1)
    +    val coresPerTask = app.desc.coresPerTask
    +    val minCoresPerExecutor = math.max(coresPerExecutor.getOrElse(1), coresPerTask)
    --- End diff --
    
    I don't think we should do this. If the user explicitly specified `spark.executor.cores`
they expect their executors to be scheduled with that many cores, no more no less.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message