Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: dbtsai <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-10940-spark@git.apache.org>
In-Reply-To: <git-pr-10940-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-13029][ml] fix a logistic
 regression is...
Content-Type: text/plain
Message-Id: <20160127211636.5A6ECE006B@git1-us-west.apache.org>
Date: Wed, 27 Jan 2016 21:16:36 +0000 (UTC)

Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10940#discussion_r51051184
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -417,7 +417,7 @@ class LogisticRegression @Since("1.2.0") (
             val rawCoefficients = state.x.toArray.clone()
             var i = 0
             while (i < numFeatures) {
    -          rawCoefficients(i) *= { if (featuresStd(i) != 0.0) 1.0 / featuresStd(i) else 0.0 }
    +          rawCoefficients(i) *= { if (featuresStd(i) != 0.0) 1.0 / featuresStd(i) else 1.0 }
    --- End diff --
    
    ```scala
    rawCoefficients(i) *= { if (featuresStd(i) != 0.0) 1.0 / featuresStd(i) else 1.0 / featuresMean(i) }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org