Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B127E18A95 for ; Tue, 26 Jan 2016 02:07:48 +0000 (UTC) Received: (qmail 65474 invoked by uid 500); 26 Jan 2016 02:07:48 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 65447 invoked by uid 500); 26 Jan 2016 02:07:48 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 65433 invoked by uid 99); 26 Jan 2016 02:07:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 02:07:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4B2D2E00DC; Tue, 26 Jan 2016 02:07:48 +0000 (UTC) From: liancheng To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-12935][SQL] DataFrame API for Count-Min... Content-Type: text/plain Message-Id: <20160126020748.4B2D2E00DC@git1-us-west.apache.org> Date: Tue, 26 Jan 2016 02:07:48 +0000 (UTC) Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10911#discussion_r50787971 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java --- @@ -52,6 +57,10 @@ private double eps; private double confidence; + public CountMinSketchImpl() { --- End diff -- This is required by `Externalizable`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org