spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12848][SQL] Change parsed decimal liter...
Date Sun, 17 Jan 2016 17:17:26 GMT
GitHub user hvanhovell opened a pull request:

    https://github.com/apache/spark/pull/10796

    [SPARK-12848][SQL] Change parsed decimal literal datatype from Double to Decimal

    The current parser turns a decimal literal, for example ```12.1```, into a Double. The
problem with this approach is that we convert an exact literal into a non-exact ```Double```.
The PR changes this behavior, a Decimal literal is now converted into an extact ```BigDecimal```.
    
    The behavior for scientific decimals, for example ```12.1e01```, is unchanged. This will
be converted into a Double. 
    
    cc @davies @rxin

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hvanhovell/spark SPARK-12848

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10796
    
----
commit f5ecab6431951fa6314a36f6f73bd50562bb31bc
Author: Herman van Hovell <hvanhovell@questtec.nl>
Date:   2016-01-17T17:08:27Z

    Change parsed decimal literal datatype from Double to Decimal

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message