spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...
Date Sun, 31 Jan 2016 07:23:07 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10989#discussion_r51356447
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
    @@ -31,22 +33,20 @@
      * TODO: replaced it by batched columnar format.
      */
     public class BufferedRowIterator {
    -  protected InternalRow currentRow;
    +  protected LinkedList<InternalRow> currentRows = new LinkedList<>();
    --- End diff --
    
    orthogonal to this pr -- my first reaction to this is that maybe we should spend a week
or two to convert all operators to a push-based model. Otherwise performance is going to suck
big time for some operators.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message