spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjffdu <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11691][SQL] Allow to specify compressio...
Date Fri, 29 Jan 2016 07:50:54 GMT
Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9657#discussion_r51233700
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala
---
    @@ -235,11 +236,18 @@ object ResolvedDataSource extends Logging {
             // For partitioned relation r, r.schema's column ordering can be different from
the column
             // ordering of data.logicalPlan (partition columns are all moved after data column).
 This
             // will be adjusted within InsertIntoHadoopFsRelation.
    +
    +        val codec = options.get("compression.codec").flatMap(e =>
    +          Some(new CompressionCodecFactory(sqlContext.sparkContext.hadoopConfiguration)
    +            .getCodecClassByName(e).asInstanceOf[Class[CompressionCodec]])
    --- End diff --
    
    they could, but we didn't expose the compression property to user. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message