spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12828][SQL]add natural join support
Date Thu, 28 Jan 2016 19:36:58 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10762#discussion_r51175030
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
    @@ -104,6 +105,9 @@ trait CheckAnalysis {
                   s"filter expression '${f.condition.prettyString}' " +
                     s"of type ${f.condition.dataType.simpleString} is not a boolean.")
     
    +          case j @ Join(_, _, NaturalJoin(_), _) =>
    +            failAnalysis(s"natural join not resolved.")
    --- End diff --
    
    if this happens, it must because join operator itself has some problems, but not caused
by the `NaturalJoin` type. I think we should remove this case and let other checking rules
to tell users what's wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message