spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Date Thu, 28 Jan 2016 09:18:46 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10723#discussion_r51096951
  
    --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
    @@ -465,7 +467,7 @@ Identifier
     fragment    
     QuotedIdentifier 
         :
    -    '`'  ( '``' | ~('`') )* '`' { setText(getText().substring(1, getText().length() -1
).replaceAll("``", "`")); }
    +    '`'  ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``", "`")); }
    --- End diff --
    
    Then I think we can make `cleanIdentifier` to strip the inital and final backticks for
this case too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message