spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12749][SQL] add json option to parse fl...
Date Wed, 27 Jan 2016 21:16:13 GMT
Github user blbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10936#discussion_r51051135
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala
---
    @@ -135,7 +136,10 @@ private[json] object InferSchema {
                 DecimalType(v.precision(), v.scale())
               case FLOAT | DOUBLE =>
                 // TODO(davies): Should we use decimal if possible?
    -            DoubleType
    +            if (configOptions.floatAsBigDecimal) {
    +              val v = parser.getDecimalValue
    +              DecimalType(v.precision(), v.scale())
    +            } else DoubleType
    --- End diff --
    
    @rxin I updated the code. Can you start Jenkins please?
    
    > On Jan 26, 2016, at 7:44 PM, Reynold Xin <notifications@github.com> wrote:
    > 
    > In sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala:
    > 
    > > @@ -135,7 +136,10 @@ private[json] object InferSchema {
    > >              DecimalType(v.precision(), v.scale())
    > >            case FLOAT | DOUBLE =>
    > >              // TODO(davies): Should we use decimal if possible?
    > > -            DoubleType
    > > +            if (configOptions.floatAsBigDecimal) {
    > > +              val v = parser.getDecimalValue
    > > +              DecimalType(v.precision(), v.scale())
    > > +            } else DoubleType
    > add curly braces around DoubleTYpe. i.e.
    > 
    > } else {
    >   DoubleTYpe
    > }
    > —
    > Reply to this email directly or view it on GitHub.
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message