spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10509][PYSPARK] Reduce excessive param ...
Date Tue, 26 Jan 2016 22:45:23 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10216#discussion_r50913777
  
    --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
    @@ -171,12 +169,10 @@ def get$Name(self):
         Mixin for Decision Tree parameters.
         """
     
    -    # a placeholder to make it appear in the generated doc
         $dummyPlaceHolders
     
         def __init__(self):
    -        super(DecisionTreeParams, self).__init__()
    -        $realParams'''
    +        super(DecisionTreeParams, self).__init__()'''
         dtParamMethods = ""
         dummyPlaceholders = ""
         realParams = ""
    --- End diff --
    
    realParams no longer needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message