spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12828][SQL]add natural join support
Date Tue, 26 Jan 2016 07:51:16 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10762#discussion_r50803191
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -474,6 +474,7 @@ class DataFrame private[sql](
               val rightCol = withPlan(joined.right).resolve(col).toAttribute.withNullability(true)
               Alias(Coalesce(Seq(leftCol, rightCol)), col)()
             }
    +      case NaturalJoin(_) => sys.error("NaturalJoin with using clause is not supported.")
    --- End diff --
    
    Are we going to support natural join in `DataFrame`? If so, I think we should also change
`JoinType.apply`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message