spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12895][SPARK-12896] Migrate TaskMetrics...
Date Tue, 26 Jan 2016 01:41:55 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10835#discussion_r50786113
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
    @@ -115,22 +118,34 @@ case class ExceptionFailure(
         description: String,
         stackTrace: Array[StackTraceElement],
         fullStackTrace: String,
    -    metrics: Option[TaskMetrics],
    -    private val exceptionWrapper: Option[ThrowableSerializationWrapper])
    +    exceptionWrapper: Option[ThrowableSerializationWrapper],
    +    accumUpdates: Seq[AccumulableInfo] = Seq.empty[AccumulableInfo])
       extends TaskFailedReason {
     
    +  // For backward compatibility; this was replaced with `accumUpdates` in Spark 2.0.
    --- End diff --
    
    Should we mark this as deprecated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message