spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12688][SQL] Fix spill size metric in un...
Date Sun, 24 Jan 2016 20:17:55 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10634#discussion_r50641512
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
    @@ -125,7 +125,8 @@ public UnsafeKVExternalSorter(
     
           // reset the map, so we can re-use it to insert new records. the inMemSorter will
not used
           // anymore, so the underline array could be used by map again.
    -      map.reset();
    +      final long spillSize = map.reset();
    +      taskContext.taskMetrics().incMemoryBytesSpilled(spillSize);
    --- End diff --
    
    Ping @carsonwang, do you plan to update this PR to address my comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message