spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...
Date Sun, 24 Jan 2016 20:06:18 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8785#discussion_r50641262
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
    @@ -37,6 +37,9 @@ private[sql] case class JDBCPartitioningInfo(
         numPartitions: Int)
     
     private[sql] object JDBCRelation {
    +
    +  import scala.collection.JavaConverters._
    --- End diff --
    
    Hey @tribbloid, #10519 has now been merged, so I think things should be in a much more
testable state now in case you want to revive this PR and try to get it merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message