spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...
Date Tue, 19 Jan 2016 20:04:14 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9940#discussion_r50166920
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
    @@ -330,9 +331,56 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with
SharedSQLContex
     
             // If the "c = 1" filter gets pushed down, this query will throw an exception
which
             // Parquet emits. This is a Parquet issue (PARQUET-389).
    +        val df = sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1").selectExpr("c",
"b", "a")
             checkAnswer(
    -          sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1").selectExpr("c", "b",
"a"),
    +          df,
               (1 to 1).map(i => Row(i, i.toString, null)))
    --- End diff --
    
    Since you are updating this test case, this line can be simplified to `Row(1, "1", null)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message