spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12887] Do not expose var's in TaskMetri...
Date Mon, 18 Jan 2016 23:56:23 GMT
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/10815#issuecomment-172687398
  
    I'm all finished with my review pass. I have two main pieces of feedback:
    
    - I think there's some opportunity to clean up the use of multiple `Option`s in `PairRDDFunctions`,
which could help to make the code easier to understand.
    - I have a question RE source/binary compatibility concerns for the changes in `TaskMetrics.
    
    Aside from those things, this looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message