spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mallman <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12755][CORE] Stop the event logger befo...
Date Mon, 18 Jan 2016 06:40:17 GMT
Github user mallman commented on the pull request:

    https://github.com/apache/spark/pull/10700#issuecomment-172440507
  
    Hi Josh,
    
    Good questions. I may have submitted this PR incorrectly. Perhaps you can guide me in
the right direction.
    
    I submitted this PR for merging into master because my understanding is that's how all
PR's for the Spark project should be created. And patches against master may be backported
to earlier releases. However, I originally created and tested this patch on branch-1.5 because
that's what we're currently running. So while this patch may be irrelevant to master (or Spark
2.0), it's relevant to the Spark 1.5 branch and presumably 1.6 as well. Under these circumstances,
should I have submitted a PR against master as I have done? The code contribution guidelines
state that only in a special case would a PR be opened against another branch. Does a patch
with no or lesser relevance to the master branch compared to an earlier release branch qualify
as a "special case"? And if so, which branch should I have submitted the PR against?
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message