spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12804][ML] Fix LogisticRegression with ...
Date Mon, 18 Jan 2016 00:35:53 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10743#discussion_r49955604
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
    @@ -883,6 +884,27 @@ class LogisticRegressionSuite
         assert(model1a0.intercept ~== model1b.intercept absTol 1E-3)
       }
     
    +  test("logistic regression with fitIntercept=true and all labels the same") {
    +    val lr = new LogisticRegression()
    +      .setFitIntercept(true)
    +      .setMaxIter(3)
    +    val sameLabels = dataset
    +      .withColumn("zeroLabel", lit(0.0))
    +      .withColumn("oneLabel", lit(1.0))
    +
    +    val allZeroModel = lr
    +      .setLabelCol("zeroLabel")
    +      .fit(sameLabels)
    +    assert(allZeroModel.coefficients ~== Vectors.dense(0.0) absTol 1E-3)
    +    assert(allZeroModel.intercept === Double.NegativeInfinity)
    +
    +    val allOneModel = lr
    +      .setLabelCol("oneLabel")
    +      .fit(sameLabels)
    +    assert(allOneModel.coefficients ~== Vectors.dense(0.0) absTol 1E-3)
    +    assert(allOneModel.intercept === Double.PositiveInfinity)
    +  }
    +
    --- End diff --
    
    Can you add one test which is all labels the same but `fitIntercept=false` here to avoid
the issue in LiR? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message