spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-12639 SQL Improve Explain for Datasource...
Date Sun, 17 Jan 2016 19:58:01 GMT
Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/10655#issuecomment-172371851
  
    @RussellSpitzer Thank you for the comment. I totally agree with you.
    
    As mentioned before, my only concern is that for ORC/Parquet, we will not be able to see
pushed filters in the explain output after the current change in this PR. As a user of Parquet/ORC,
I do want to see that a filter has been pushed down even if this filter will not be applied
to every row.
    
    How about we go with Asterisks for now? You may need to keep the expression that maps
to a data source filter (https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala#L536)
to generate the string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message