spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...
Date Wed, 13 Jan 2016 04:51:58 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10577#discussion_r49551487
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
    @@ -123,6 +115,39 @@ case class Except(left: LogicalPlan, right: LogicalPlan) extends
SetOperation(le
       override def output: Seq[Attribute] = left.output
     }
     
    +/** Factory for constructing new `Union` nodes. */
    +object Union {
    +  def apply(left: LogicalPlan, right: LogicalPlan): Union = {
    +    Union (left :: right :: Nil)
    +  }
    +}
    +
    +case class Union(children: Seq[LogicalPlan]) extends LogicalPlan {
    +
    +  // updating nullability to make all the children consistent
    +  override def output: Seq[Attribute] =
    +    children.map(_.output).transpose.map(attrs =>
    +      attrs.head.withNullability(attrs.exists(_.nullable)))
    +
    +  override lazy val resolved: Boolean = {
    +    lazy val allChildrenCompatible: Boolean =
    --- End diff --
    
    Sure, will try it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message