spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dilipbiswal <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...
Date Mon, 11 Jan 2016 19:20:38 GMT
Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10520#discussion_r49364948
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala ---
    @@ -123,6 +126,24 @@ private[hive] object HiveShim {
         // for Serialization
         def this() = this(null)
     
    +    override def hashCode(): Int = {
    +        if (instance != null && instance.isInstanceOf[GenericUDFMacro]) {
    --- End diff --
    
    @yhuai Ah.. thanks a lot. I understand now that its not possible for users to extend the
macro.I will make the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message