spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...
Date Mon, 11 Jan 2016 05:27:13 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10563#discussion_r49290887
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
    @@ -25,17 +25,26 @@ import org.apache.spark.sql.catalyst.util.TypeUtils
     import org.apache.spark.sql.types._
     import org.apache.spark.util.Utils
     
    +trait PredResult
    --- End diff --
    
    predicate is only returns `true/false`, but also possible be `null`, however, `null` will
be casted into `false` in scala, but this is important for `antijoin`.
    ```scala
    scala> val a: Any = null
    a: Any = null
    
    scala> a.asInstanceOf[Boolean]
    res0: Boolean = false
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message