spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12437][SQL] Encapsulate the table and c...
Date Sat, 09 Jan 2016 18:19:57 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10403#discussion_r49266410
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
    @@ -41,6 +41,26 @@ private case object MySQLDialect extends JdbcDialect {
       override def quoteIdentifier(colName: String): String = {
         s"`$colName`"
       }
    +  
    +  override def parseTableName(tableName: String): String = {
    +    val tableName1 = tableName.replace("\"", "").replace("\'", "")
    --- End diff --
    
    Also, `tableName1` is a bad name; if you were going to go with this approach, I'd call
it something like `tableNameWithoutQuotes` (but I'm not sure that this unconditional quote-stripping
is correct).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message