spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarutak <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...
Date Fri, 08 Jan 2016 19:10:21 GMT
Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10663#discussion_r49225126
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -100,7 +101,20 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIPage("stage")
{
           val parameterTaskPrevPageSize = request.getParameter("task.prevPageSize")
     
           val taskPage = Option(parameterTaskPage).map(_.toInt).getOrElse(1)
    -      val taskSortColumn = Option(parameterTaskSortColumn).getOrElse("Index")
    +      val taskSortColumn = Option(parameterTaskSortColumn).map { sortColumn =>
    +          // SPARK-12708
    +          // Due to YARN-2844, "/" in the url will be encoded to "%252F" when
    +          // running in yarn mode. `request.getParameter("task.sort")` will return
    +          // "%252F". Therefore we need to decode it until we get the real column name.
    +          // SPARK-4313 is similar to this issue.
    +          var column = sortColumn
    --- End diff --
    
    Make sense. 
    @yoshidakuy can you add a new method to `UIUtils` to reduce the similar logic.
    Then, call it from `ExecutorThreadDumpPage` and `StagePage`.
    Also, could you add a test case for the new method to `UIUtilsSuite`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message