spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...
Date Thu, 07 Jan 2016 20:18:18 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10609#discussion_r49120662
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/StateMap.scala ---
    @@ -17,16 +17,20 @@
     
     package org.apache.spark.streaming.util
     
    -import java.io.{ObjectInputStream, ObjectOutputStream}
    +import java.io._
     
     import scala.reflect.ClassTag
     
    +import com.esotericsoftware.kryo.{Kryo, KryoSerializable}
    +import com.esotericsoftware.kryo.io.{Input, Output}
    +
     import org.apache.spark.SparkConf
    +import org.apache.spark.serializer.{KryoOutputObjectOutputBridge, KryoInputObjectInputBridge}
     import org.apache.spark.streaming.util.OpenHashMapBasedStateMap._
     import org.apache.spark.util.collection.OpenHashMap
     
     /** Internal interface for defining the map that keeps track of sessions. */
    -private[streaming] abstract class StateMap[K: ClassTag, S: ClassTag] extends Serializable
{
    --- End diff --
    
    Good idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message