spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12593][SQL] Converts resolved logical p...
Date Thu, 07 Jan 2016 05:43:55 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10541#discussion_r49043705
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
    @@ -163,6 +173,12 @@ sealed abstract class AggregateFunction extends Expression with ImplicitCastInpu
       def toAggregateExpression(isDistinct: Boolean): AggregateExpression = {
         AggregateExpression(aggregateFunction = this, mode = Complete, isDistinct = isDistinct)
       }
    +
    +  override def sql: Option[String] = argumentsSQL.map(sql => s"${prettyName.toUpperCase}($sql)")
    --- End diff --
    
    Sounds reasonable. I'm removing `sql` and `argumentsSQL` in `AggregateFunction`. Also
removing `toUpperCase` calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message