spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12593][SQL] Converts resolved logical p...
Date Thu, 07 Jan 2016 04:10:48 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10541#discussion_r49040368
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
---
    @@ -49,6 +49,8 @@ abstract class RDG extends LeafExpression with Nondeterministic {
       override def nullable: Boolean = false
     
       override def dataType: DataType = DoubleType
    +
    +  override def sql: Option[String] = Some(s"${prettyName.toUpperCase}($seed)")
    --- End diff --
    
    Just a note at here. Even if a user uses `rand()`, we will put a seed at here. (no need
to make any change for this right now)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message