spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12593][SQL] Converts resolved logical p...
Date Thu, 07 Jan 2016 03:40:21 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10541#discussion_r49039342
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
    @@ -356,6 +359,8 @@ abstract class UnaryExpression extends Expression {
           """
         }
       }
    +
    +  override def sql: Option[String] = child.sql.map(childSQL => s"($prettyName($childSQL))")
    --- End diff --
    
    Maybe it is good to add doc in the code to mention that `prettyName` should match the
name registered in function registry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message