spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NarineK <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...
Date Wed, 06 Jan 2016 19:54:27 GMT
Github user NarineK commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9667#discussion_r49001507
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
    @@ -178,7 +178,7 @@ object GradientDescent extends Logging {
           regParam: Double,
           miniBatchFraction: Double,
           initialWeights: Vector,
    -      convergenceTol: Double): (Vector, Array[Double]) = {
    +      convergenceTol: Double): (Vector, Array[Double], Integer) = {
    --- End diff --
    
    yes, I guess in this case # of iter = history length. I can remove the last argument


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message