spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...
Date Wed, 06 Jan 2016 06:23:29 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10577#discussion_r48930909
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -608,7 +609,9 @@ class Dataset[T] private[sql](
        * duplicate items.  As such, it is analogous to `UNION ALL` in SQL.
        * @since 1.6.0
        */
    -  def union(other: Dataset[T]): Dataset[T] = withPlan[T](other)(Union)
    +  def union(other: Dataset[T]): Dataset[T] = withPlan[T](other){ (left, right) =>
    --- End diff --
    
    ah damn - @marmbrus we called it union in Dataset and unionAll in DataFrame ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message