Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: andrewor14 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-10346-spark@git.apache.org>
In-Reply-To: <git-pr-10346-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-12392][Core] Optimize a location
 order ...
Content-Type: text/plain
Message-Id: <20151219020654.7B38AE097A@git1-us-west.apache.org>
Date: Sat, 19 Dec 2015 02:06:54 +0000 (UTC)

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10346#discussion_r48087373
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -578,9 +578,18 @@ private[spark] class BlockManager(
         doGetRemote(blockId, asBlockResult = false).asInstanceOf[Option[ByteBuffer]]
       }
     
    +  private def getLocations(blockId: BlockId): Seq[BlockManagerId] = {
    +    // Since block managers can share an identical host, we put these preferred
    +    // locations first.
    --- End diff --
    
    I would move this to the java doc and rephrase it
    ```
    /**
     * Return a list of locations for the given block, prioritizing the local machine since multiple
     * block managers can share the same host.
     */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org