Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: mallman <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-7345-spark@git.apache.org>
In-Reply-To: <git-pr-7345-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-8982][Core] Worker hostnames not
 showin...
Content-Type: text/plain
Message-Id: <20151217180205.10948E1026@git1-us-west.apache.org>
Date: Thu, 17 Dec 2015 18:02:05 +0000 (UTC)

Github user mallman commented on the pull request:

    https://github.com/apache/spark/pull/7345#issuecomment-165532682
  
    To add my two cents, I think that to call this change "cosmetic" is strictly true but underrates its value. In our case we have additional monitoring systems that report based on local hostname. When we want to investigate an issue we see in monitoring in the Spark UI, not having the hostnames in the UI makes it more difficult than it was in Spark 1.3. Also, because we're in AWS and use amazon's DNS for reverse lookup, we can't do a reverse lookup on the IP to see the hostname. (I know that's our problem—just illustrating the impact from our perspective.)
    
    With regard to a fix, I'm also in favor of a simple patch to `start-slave.sh`. In fact, it's something we're going to try ourselves. I'll try to get it done today and will report here on our experience.
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org