Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B3A2A1851E for ; Thu, 10 Dec 2015 14:20:10 +0000 (UTC) Received: (qmail 73595 invoked by uid 500); 10 Dec 2015 14:20:10 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 73572 invoked by uid 500); 10 Dec 2015 14:20:10 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 73561 invoked by uid 99); 10 Dec 2015 14:20:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 14:20:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 339F8E0B4E; Thu, 10 Dec 2015 14:20:10 +0000 (UTC) From: rxin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [RFC] Add type-safe config keys to SparkConf. Content-Type: text/plain Message-Id: <20151210142010.339F8E0B4E@git1-us-west.apache.org> Date: Thu, 10 Dec 2015 14:20:10 +0000 (UTC) Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-163632970 hm - is the value in doing this for core large enough yet? one problem with core is that a lot of config options are defined in yarn, etc, outside of core. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org