Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: windscope <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-10163-spark@git.apache.org>
In-Reply-To: <git-pr-10163-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of
 predicates ...
Content-Type: text/plain
Message-Id: <20151209061127.53EA3E0B28@git1-us-west.apache.org>
Date: Wed,  9 Dec 2015 06:11:27 +0000 (UTC)

Github user windscope commented on the pull request:

    https://github.com/apache/spark/pull/10163#issuecomment-163121275
  
    To improve semanticEquals, we tried to implement a template function `Expression.splitWithCommutativeOperator[T: Manifest](): Seq[Expression]` so that we don't need to implement a split function for each commutative operator. However, we cannot perform pattern matching on T.
    Should we simply call `PredicateHelper.splitConjunctivePredicates` in `Expression.semanticEquals` and implement a few similar split function for other commutative operators?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org