Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: vanzin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-8880-spark@git.apache.org>
In-Reply-To: <git-pr-8880-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle
 in sp...
Content-Type: text/plain
Message-Id: <20151208194317.71F13E038A@git1-us-west.apache.org>
Date: Tue,  8 Dec 2015 19:43:17 +0000 (UTC)

Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/8880#issuecomment-162993342
  
    Hi @winningsix ,
    
    Thanks for removing the old tests. There are still a few things missing here:
    - it doesn't build anymore; do you need to update the chimera version?
    - the block manager is still compressing encrypted streams, instead of encrypting compressed streams, which would be more efficient.
    - the tests currently under `yarn/` should be moved to `core/` and adjusted as needed, since that's where the code is being modified. I'd suggest finding a way to test the block manager changes without needing to run a complete Spark app.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org