spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scwf <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...
Date Wed, 09 Dec 2015 02:52:27 GMT
GitHub user scwf opened a pull request:

    https://github.com/apache/spark/pull/10213

    [SPARK-12222] [Core] Deserialize RoaringBitmap using Kryo serializer throw Buffer underflow
exception

    Deserialize RoaringBitmap using Kryo serializer throw Buffer underflow exception:
    ```
    com.esotericsoftware.kryo.KryoException: Buffer underflow.
    	at com.esotericsoftware.kryo.io.Input.require(Input.java:156)
    	at com.esotericsoftware.kryo.io.Input.skip(Input.java:131)
    	at com.esotericsoftware.kryo.io.Input.skip(Input.java:264)
    	at org.apache.spark.sql.SQLQuerySuite$$anonfun$6$KryoInputDataInputBridge$1.skipBytes
    ```
    
    This is caused by a bug of kryo's `Input.skip(long count)`(https://github.com/EsotericSoftware/kryo/issues/119)
and we call this method in `KryoInputDataInputBridge`.
    
    Instead of upgrade kryo's version, this pr bypass the  kryo's `Input.skip(long count)`
by directly call another `skip` method in kryo's Input.java(https://github.com/EsotericSoftware/kryo/blob/kryo-2.21/src/com/esotericsoftware/kryo/io/Input.java#L124),
i.e. write the bug-fixed version of `Input.skip(long count)` in KryoInputDataInputBridge's
`skipBytes` method.
    
    more detail link to https://github.com/apache/spark/pull/9748#issuecomment-162860246

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scwf/spark patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10213
    
----
commit edf438443b35e131490e8652d6382143180b9e26
Author: Fei Wang <wangfei1@huawei.com>
Date:   2015-12-09T02:41:42Z

    fix skipBytes

commit 01d37b0e1833dd17aedd27427102edef3ffdba79
Author: Fei Wang <wangfei1@huawei.com>
Date:   2015-12-09T02:45:19Z

    added test suite

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message