spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10180] [SQL] JDBC datasource are not pr...
Date Wed, 30 Dec 2015 23:58:24 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8743#discussion_r48640365
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
    @@ -191,6 +191,9 @@ private[sql] object JDBCRDD extends Logging {
        */
       private def compileFilter(f: Filter): String = f match {
         case EqualTo(attr, value) => s"$attr = ${compileValue(value)}"
    +    case EqualNullSafe(attr, value) =>
    +      s"(NOT ($attr != ${compileValue(value)} OR $attr IS NULL OR " +
    --- End diff --
    
    It took me several minutes to understand it. Maybe `(attr IS NULL AND value IS NULL) OR
(attr <> null AND value <> null AND attr = value)` is easier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message