spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...
Date Mon, 28 Dec 2015 22:07:52 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10368#discussion_r48508806
  
    --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf)
         kryo.register(classOf[SerializableJobConf], new KryoJavaSerializer())
         kryo.register(classOf[HttpBroadcast[_]], new KryoJavaSerializer())
         kryo.register(classOf[PythonBroadcast], new KryoJavaSerializer())
    +    kryo.register(classOf[TaskMetrics], new KryoJavaSerializer())
    +    kryo.register(classOf[DirectTaskResult[_]], new KryoJavaSerializer())
    +    kryo.register(classOf[IndirectTaskResult[_]], new KryoJavaSerializer())
    --- End diff --
    
    Moreover, `_accumulatorUpdates` is much more complicated. Its value could be any type,
e.g., `SQLMetricValue`. If someone adds a new `SQLMetricValue` type, it's hard for reviewers
to recall it will be stored in `TaskMetrics`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message