spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From radekg <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...
Date Fri, 25 Dec 2015 17:18:14 GMT
Github user radekg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9608#discussion_r48442211
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala ---
    @@ -122,7 +122,8 @@ private[netty] class NettyRpcEnv(
     
       @Nullable
       override lazy val address: RpcAddress = {
    -    if (server != null) RpcAddress(host, server.getPort()) else null
    +    if (server != null)
    +      RpcAddress(host, conf.getInt("spark.driver.advertisedPort", server.getPort()))
else null
    --- End diff --
    
    My assumption was that this was the safest behaviour for the Netty based rpc. If the `spark.driver.advertisedPort`
setting is `0`, it's an operator error, no different than setting the value to, say, `1`.
Not sure if there is any value in testing for `0` here. Ideas welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message