spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12446][SQL] Add unit tests for JDBCRDD ...
Date Tue, 22 Dec 2015 06:42:15 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10409#discussion_r48225878
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
    @@ -168,6 +168,35 @@ private[sql] object JDBCRDD extends Logging {
       }
     
       /**
    +   * Converts value to SQL expression.
    +   */
    +  private def compileValue(value: Any): Any = value match {
    --- End diff --
    
    I just moved `compileValue`, `escapeSql`, and `compileFilter` in this companion object
area.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message