spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongwang218 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6964][SQL] Support Cancellation in the ...
Date Tue, 22 Dec 2015 04:33:22 GMT
Github user dongwang218 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6207#discussion_r48221224
  
    --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
    @@ -335,6 +336,42 @@ class HiveThriftBinaryServerSuite extends HiveThriftJdbcTest {
           }
         )
       }
    +
    +  test("test jdbc cancel") {
    +    withJdbcStatement { statement =>
    +      val queries = Seq(
    +        "DROP TABLE IF EXISTS test_map",
    +        "CREATE TABLE test_map(key INT, value STRING)",
    +        s"LOAD DATA LOCAL INPATH '${TestData.smallKv}' OVERWRITE INTO TABLE test_map")
    +
    +      queries.foreach(statement.execute)
    +
    +      val largeJoin = "SELECT COUNT(*) FROM test_map " +
    +        List.fill(10)("join test_map").mkString(" ")
    +      val f = future { Thread.sleep(100); statement.cancel(); }
    --- End diff --
    
    Yes, +1 for a more reliable way to trigger cancel after submitting the long execution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message