spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <>
Subject [GitHub] spark pull request: [SPARK-12392][Core] Optimize a location order ...
Date Mon, 21 Dec 2015 18:55:01 GMT
Github user andrewor14 commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -578,9 +578,19 @@ private[spark] class BlockManager(
         doGetRemote(blockId, asBlockResult = false).asInstanceOf[Option[ByteBuffer]]
    +  private def getLocations(blockId: BlockId): Seq[BlockManagerId] = {
    +    /**
    +     * Return a list of locations for the given block, prioritizing the local machine
    +     * multiple block managers can share the same host.
    +     */
    --- End diff --
    Java docs should live outside the `def`, not inside. I'll fix this myself when I merge

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message