spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MLnick <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...
Date Mon, 21 Dec 2015 06:36:30 GMT
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10152#discussion_r48119953
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -77,6 +77,20 @@ class Word2Vec extends Serializable with Logging {
       private var numIterations = 1
       private var seed = Utils.random.nextLong()
       private var minCount = 5
    +  private var maxSentenceLength = 1000
    +
    +  /**
    +   * sets the maxSentenceLength, maxSentenceLength is used as the threshold for cutting
sentence
    --- End diff --
    
    One final thing - can you address the comment above? And I think we can actually remove
the `@param` and `@return` to match the comments for the other setters in this class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message