spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12392][Core] Optimize a location order ...
Date Sat, 19 Dec 2015 02:05:02 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10346#discussion_r48087346
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -578,9 +578,18 @@ private[spark] class BlockManager(
         doGetRemote(blockId, asBlockResult = false).asInstanceOf[Option[ByteBuffer]]
       }
     
    +  private def getLocations(blockId: BlockId): Seq[BlockManagerId] = {
    +    // Since block managers can share an identical host, we put these preferred
    +    // locations first.
    +    val locs = Random.shuffle(master.getLocations(blockId))
    +    val preferredLocs = locs.filter(loc => blockManagerId.host == loc.host)
    +    val otherLocs = locs.filter(loc => blockManagerId.host != loc.host)
    --- End diff --
    
    you could do
    ```
    val (preferredLocs, otherLocs) = locs.partition { loc => blockManagerId.host == loc.host
}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message