spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...
Date Thu, 17 Dec 2015 18:57:59 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10353#discussion_r47945571
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -511,9 +509,26 @@ class DataFrame private[sql](
           catalyst.expressions.And(cond, eqTo)
         }
     
    +    // Project only one of the join columns.
    +    val joinedCols = JoinType(joinType) match {
    +      case Inner | LeftOuter | LeftSemi =>
    +        usingColumns.map(col => withPlan(joined.left).resolve(col))
    +      case RightOuter =>
    +        usingColumns.map(col => withPlan(joined.right).resolve(col))
    +      case FullOuter =>
    +        usingColumns.map { col =>
    +          val leftCol = withPlan(joined.left).resolve(col)
    +          val rightCol = withPlan(joined.right).resolve(col)
    +          Alias(Coalesce(Seq(leftCol, rightCol)), col)()
    +        }
    +    }
    +    // The nullability of output of joined could be different than original column,
    +    // so we can only compare them by exprId
    +    val joinRefs = condition.map(_.references.toSeq.map(_.exprId)).getOrElse(Nil)
    +    val resultCols = joinedCols ++ joined.output.filterNot(e => joinRefs.contains(e.exprId))
    --- End diff --
    
    Yes, but that is exactly what an `AttributeSet` is for.  It is a set that only compares
the id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message